Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(debug): add ability to override the debugPrint statement #2337

Merged
merged 4 commits into from
Mar 11, 2024
Merged

chore(debug): add ability to override the debugPrint statement #2337

merged 4 commits into from
Mar 11, 2024

Conversation

josegonzalez
Copy link
Contributor

This allows users to use a single logger within their application for all printing, regardless of level.

  • With pull requests:
    • Open your pull request against master
    • Your pull request should have no more than two commits, if not you should squash them.
    • It should pass all tests in the available continuous integration systems such as TravisCI.
    • You should add/modify tests to cover your proposed code changes.
    • If your pull request contains a new feature, please document it on the README.

@josegonzalez
feat: add ability to override the debugPrint statement
8143323 
This allows users to use a single logger within their application for all printing, regardless of level.
@codecov
Copy link

codecov bot commented Apr 23, 2020 •
edited
Loading

Codecov Report

Merging #2337 (8143323) into master (4ea0e64) will decrease coverage by 0.71%.
The diff coverage is 66.66%.

❗ Current head 8143323 differs from pull request most recent head 5f3d252. Consider uploading reports for the commit 5f3d252 to get more accurate results

@@            Coverage Diff             @@
##           master    #2337      +/-   ##
==========================================
- Coverage   99.01%   98.30%   -0.71%     
==========================================
  Files          42       41       -1     
  Lines        3157     2307     -850     
==========================================
- Hits         3126     2268     -858     
- Misses         21       23       +2     
- Partials       10       16       +6
Flag Coverage Δ
?
go-1.18 ?
go-1.19 ?
go-1.20 ?
macos-latest ?
ubuntu-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
debug.go 86.79% <66.66%> (-4.88%) ⬇️

... and 38 files with indirect coverage changes

@josegonzalez
Copy link
Contributor Author

Any chance of this being mergeable?

@appleboy appleboy added this to the v1.10 milestone Jun 3, 2023
appleboy
appleboy requested changes Jun 3, 2023
View reviewed changes
debug.go Outdated Show resolved Hide resolved
appleboy
appleboy requested changes Jun 3, 2023
View reviewed changes
debug.go Outdated Show resolved Hide resolved
@appleboy appleboy changed the title feat: add ability to override the debugPrint statement chore(debug): add ability to override the debugPrint statement Mar 11, 2024
@appleboy appleboy merged commit 1b3c085 into gin-gonic:master Mar 11, 2024
@josegonzalez josegonzalez deleted the patch-1 branch March 12, 2024 03:20
@josegonzalez
Copy link
Contributor Author

Thanks for merging this! Much appreciated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.
2 participants
@josegonzalez @appleboy